Its not possible to change the download folder due to hardcoded storagepath in startup scripts

[advorsky73]

Is there an existing issue for this?

• [X] I have searched the existing issues

Current Behavior

you can change the download folder in settings/general as often as you like, it will be overriden by startup parameter --storagepath via startup scripts

Expected Behavior

the configured download path, e.g. /downloads/activedownloads, should PERSIST and be taken as download path after a restart.

Steps To Reproduce

start container, change settings/general/download path to e.g. /download/active. restart container. download path is back to /downloads

Environment

- OS: Unraid 6.11.5
- How docker service was installed: by OS

CPU architecture

x86-64

Docker creation

unraid app pyload-ng

Container logs

[2023-02-17 15:16:36]  INFO                pyload  *** Welcome to pyLoad 0.5.0 ***
[2023-02-17 15:16:36]  DEBUG               pyload  Indexing plugins...
[2023-02-17 15:16:37]  INFO                pyload  ADDON ExternalScripts: Activated scripts in folder `package_finished`: package_finished
[2023-02-17 15:16:37]  INFO                pyload  Activated addons: ClickNLoad, ExternalScripts, TORRENT, UnSkipOnFail, UserAgentSwitcher
[2023-02-17 15:16:37]  INFO                pyload  Deactivate addons: AndroidPhoneNotify, AntiCaptcha, AntiStandby, AntiVirus, AppriseNotify, BypassCaptcha, Captcha9Kw, Checksum, CloudFlareDdos, DeathByCaptcha, DeleteFinished, DiscordNotifier, DownloadScheduler, ExpertDecoders, ExtractArchive, HotFolder, IRC, ImageTyperz, JustPremium, LinkFilter, LogMarker, MergeFiles, MultiHome, PushBullet, PushOver, RestartFailed, SkipRev, TransmissionRPC, UpdateManager, WindowsPhoneNotify, XFileSharing, XMPP
[2023-02-17 15:16:37]  DEBUG               pyload  Starting core...
[2023-02-17 15:16:37]  DEBUG               pyload  Debug level: TRACE
[2023-02-17 15:16:37]  DEBUG               pyload  Setup language...
[2023-02-17 15:16:37]  DEBUG               pyload  Setup permissions...
[2023-02-17 15:16:37]  INFO                pyload  User directory: /config
[2023-02-17 15:16:37]  INFO                pyload  Cache directory: /tmp/pyLoad
[2023-02-17 15:16:37]  INFO                pyload  Storage directory: /downloads

[github-actions[bot]]

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[advorsky73]

👍

[aptalca]

@advorsky73 To circle back, that is the intended behavior. You change the download path by changing the volume mapping for /downloads in docker arguments.

[advorsky73]

I am well aware of that, thanks for pointing out the obvious... However, if you have specialized subfolders, e.g. Finished Downloads for Downloads, Watch for Hotfolders and maybe ExtractedDownloads for extracted downloads, then you need to add all of those via seperate docker mappings instead of one, which is quite annoying instead of just changing the settings in pyload to /downloads/FinishedDownloads and have just one mapping of /downloads and 3 (or more) used folders in pyload... The way pyload is started in this container makes the setting within completely obsolete, therefore i dont see this as a good design because it limits users.

[aptalca]

https://www.linuxserver.io/blog/2019-09-14-customizing-our-containers

[advorsky73]

Thanks for the link, I was not aware of this feature... leant something 😉

However this makes it worse for me than better 🤣 Dont get me wrong, I do love linuxserver's images and i use a lot of them on my Unraid servers. This one however is the first one I came across which criples/limits the software it runs, which is very unusual. It is sad to see how this is handled, I just wanted you to give the chance to fix this, as the fix is extremely simple by removing a hardcoded cmdline parameter. I will continue the use of it with my 3 docker paths instead of 1 then 🤷‍♂️ Toodaloo...

[aptalca]

I'll be blunt.

What seems like a simple fix to you (because you have a very specific and uncommon need that is entirely your personal preference), is actually something that would lead to a lot of broken installs and support requests for us.

Most of our users are docker novices (linux novices as well). If we make them set a volume map for /downloads, they should expect the downloads to be in that folder. Hence the hardcode. It just works. Imagine we didn't, lots of users would see the setting in the gui and change it to a host folder (because a lot of our users don't quite understand docker's volume mapping either), and they would complain about the downloads not appearing in the correct folder, and that their docker image is filling up, etc. etc.

Our design principle is to streamline things enough that the majority needs are met, but with minimal support requests because we have a small volunteer team.

[advorsky73]

Let me be blunt as well then...

2 minutes of searching in the code repo of pyload and you would have seen that ~/Downloads/pyLoad is the default. So instead of hardcoding the path, you could have supported the default by documenting it and having the unraid templates have it by default as storage path in the mapping. But you took the easy way instead of delivering a good design on that one image.

So to be really blunt, you were just lazy on this one. Nothing else. And given that this issue was reported on February 17th 2023 without ANY reaction of anyone else than a bot for 3 month, supports my statement.

Toodaloo...

[advorsky73]

PS: If you would have stated, we dont have the manpower to make this the correct way, I would have more understanding for the situation, but you chose to defend a faulty design.

[aptalca]

sigh and the convo quickly degrades to accusations and name calling Consider this your first warning. We do not tolerate abusive behavior

[github-actions[bot]]

This issue is locked due to inactivity