search

linuxserver / docker-swag

Nginx webserver and reverse proxy with php support and a built-in Certbot (Let's Encrypt) client. It also contains fail2ban for intrusion prevention.
https://docs.linuxserver.io/general/swag
GNU General Public License v3.0
2.81k stars 242 forks source link

[FEAT] systemd socket activation #408

Closed virtorgan closed 9 months ago

virtorgan commented 1 year ago

Is this a new feature request?

Wanted change

Systemd socket activation does not work with Swag while it works with official NGINX image.

Reason for change

Tendency is to evolve to rootless containers thus people move away from Docker to more secure rootless Podman. Networking in rootless is slower due to the use of Slirp4netns which adds processing. other solution like Netavark or bypass4netns still need processing time. the fastest (and maybe more secure) way would be to use socket activation of swag container.

Proposed code change

official docker-nginx have already made the changes to allow socket activation. see https://github.com/nginxinc/docker-nginx/issues/702

Would be nice to get same modifications for swag.

github-actions[bot] commented 1 year ago

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

drizuid commented 1 year ago

Unfortunately, we do not test or support podman (or rootless on any platform, including docker). An enhancement like this would require someone with the understanding of our s6 init process to submit a fully functional PR that supports this while not impacting our target audience in any way. This is not something that we as a team plan to work on.

LinuxServer-CI commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 8 months ago

This issue is locked due to inactivity