search

linz / gazetteer

New Zealand Gazetteer of official place names
http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT
Other
2 stars 2 forks source link

chore: MIT license #39 #55

Closed SPlanzer closed 4 years ago

SPlanzer commented 4 years ago

Fixes: #

39

Change Description:

License updated to MIT

Notes for Testing:

Source Code Documentation Tasks:

User Documentation Tasks:

Testing Tasks:

Pull Request Management:

palmerj commented 4 years ago

You will need to change (or remove?) the licence file in the src directory, and also updated all file headers

SPlanzer commented 4 years ago

You will need to change (or remove?) the licence file in the src directory, and also updated all file headers

yeah, thanks @palmerj

billgeo commented 4 years ago

Isn't it optional to add it to the file header? The MIT license just says:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

Which you could interpret as a license file in the root of the repo? Anyway would be good to have a common way of doing this for LINZ I suppose. Part of the open sourcing guide/checklist thing?

palmerj commented 4 years ago

It's best practise to include the licence type in the header of source files to avoid confusion (also helps if you add another 3rd party source file to the project which has another licence, or a single file get separated from the repo distribution).

SPlanzer commented 4 years ago

Ready for review

A grep shows no reference to BSD in source code

palmerj commented 4 years ago

Thanks. I think if we are going to make some changes here to MIT it would be good to following standard DIA advice. LICENCE files should be:

MIT Licence

New Zealand Geographic Board gazetteer application, Crown copyright (c) 2015, Land Information New Zealand on behalf of the New Zealand Government.

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

and the source headers should read:

New Zealand Geographic Board gazetteer application, Crown copyright (c) 2020, Land Information New Zealand on behalf of the New Zealand Government. This file is released under the MIT licence. See the LICENCE file found in the top-level directory of this distribution for more information.

See https://www.data.govt.nz/manage-data/policies/nzgoal/nzgoal-se/#licensing-of-accompanying-documentation

palmerj commented 4 years ago

We should also rename the licence file in the root directory to LICENSE.md

SPlanzer commented 4 years ago

@palmerj you commented heavily on this, I am looking for approval, you are probably the must up to speed with this PR to do so.

palmerj commented 4 years ago

No problem. Just assign it to me. I check https://github.com/pulls/review-requested each day for PR I've been asked to review before merging.

SPlanzer commented 4 years ago

Done, thanks @palmerj