search

linz / gazetteer

New Zealand Gazetteer of official place names
http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT
Other
2 stars 2 forks source link

Remove carriage returns from SQL files #68

Closed strk closed 4 years ago

strk commented 4 years ago

Should help future formatting

SPlanzer commented 4 years ago

There are some aspects of this I am still not clear on after reading the documentation.

Mainly, for this tool to be effective it will need to be executed on each commit in github. I would normally integrate this with github actions however as far as I can see this tool has no CLI.

What is the best way to ensure all code committers are using this?

billgeo commented 4 years ago

@SPlanzer have you seen this https://github.com/marketplace/actions/editorconfig-action?

strk commented 4 years ago

This PR is not aimed at enforcing a specific format, just:

  1. Document what we want
  2. Allow developers to configure their editor to follow the recomendation

The above is what Editorconfig does.

Enforcing the format was out of scope here, as well as checking if the current format matches what we want. But they are both (in reverse order) good follow up steps.

strk commented 4 years ago

Ok I changed scope if this PR to only remove carriage returns from files, filing another PR to add the .editorconfig file to document that's what we want (##71)

strk commented 4 years ago

Let's simplify things: #72 includes this so will close this PR