linz / nz-buildings

:house: NZ Buildings | QGIS plugin and PostGIS database schema for building dataset management
https://nz-buildings.rtfd.io
Other
6 stars 2 forks source link

Update name attribute for suburb_locality #653

Closed YingtingChen closed 1 month ago

YingtingChen commented 2 months ago

Change Description:

Update the name attribute from 'suburb_4th', 'suburb_3rd', 'suburb_2nd', ' suburb_1st' to 'name', using the new NZ Suburbs and Localities schema.

Notes for Testing:

All test (db+plugin) passed.

Note that there's one test commented out - https://github.com/linz/nz-buildings/blob/master/buildings/tests/gui/test_processes_update_reference_data_admin_bdys.py I've checked that and make sure the failure was due to the previous found issue not the changes here. This test will be remove once we develop the new method for ref update. ...

Source Code Documentation Tasks:

~- [ ] README updated (where applicable)~ ~- [ ] CHANGELOG (Unreleased section) updated~ will update in the next PR ~- [ ] Docstrings / comments included to help explain code~

User Documentation Tasks:

~- [ ] Confluence user guide updated (where applicable)~

Testing Tasks: