search

lipido / kargos

KDE Plasma port of GNOME Argos and OSX BitBar
GNU General Public License v3.0
126 stars 13 forks source link

Vertical-align and margin are not nice. #1

Closed trmdi closed 7 years ago

trmdi commented 7 years ago

It's like the "Vertical-align" isn't aligned to the middle, and the left/right margin is a little too far. See the screenshot below:

screenshot

The .sh file:

#!/bin/bash
echo "en | font=HackBold size=13"
lipido commented 7 years ago

I think Vertical-align it is now fixed in github. Could you try? To test:

git clone git@github.com:lipido/kargos.git
cd kargos

plasmapkg2 --remove org.kde.kargos
plasmapkg2 -t plasmoid --install .plasmoid
killall plasmashell; kstart5 plasmashell
trmdi commented 7 years ago

Ok, it is vertically aligned. Looks much better now. About the left/right margin, after checked again, I think that space is the margin of others widget.

I have some other suggestions:

  1. Which effect do you think better when the mouse hovers over the button? I think the one of the Share widget. (The run button is not as nice as the Share widget with the border when mouse hovers over. I mean you just need to add the border, no need to display the run button)
  2. I also think it would be better if you let the user change the text when the mouse hovers over the button. (the text "kargos" and "Argos port to KDE Plasma") 1 2
  3. What about an option for "preferred height" ? 3
  4. What do you think about a new name for kargos? Don't need to keep the old name "argos". It doesn't suggest anything to one who has never used it before like me. What about "Fluid"? :D
lipido commented 7 years ago

Hi, awesome review!

  1. The Run button appears only on items which have bash attribute. A Go button also appears on items with href attribute. The aspect is a standard button, nothing else. I've used buttons because you can have href and bash in the same item, so a click over the item is ambiguous, so I've used two buttons.

  2. The tooltip is not a tooltip of the Run button, is a tooltip of the entire plasmoid. In any case, I think that a static text like is is currently implemented or a configuration option to place just another static text is not very useful. What about this idea? Place contents taken from the command execution to create useful and dynamic tooltips. For example, creating a non BitBar standard attribute like tooltipmain and tooltipsub. An example code:

    
#!/bin/bash

echo "en" # text on the panel echo "Cool kargo plugin | tooltipmain=true" echo "This kargo plugin shows the new tooltip feature $(date) | tooltipsub=true"



3. Implemented, just committed. :-)

4. The name... I didn't know argos nor bibar, but I saw a post in the las few days and I thought that it was so awesome that I was forced to learn to program plasmoids and take it into my beloved KDE :-). The name is a tribute to those apps.
alxlg commented 7 years ago

@trmdi I think the hover effect should be the one of the other plasmoids (like sys tray). The effect of share button is a bug and if I remember correctly is fixed in git.

alxlg commented 7 years ago

@lipido git clone git@github.com:lipido/kargos.git gives me error about denied permission. git clone https://github.com/lipido/kargos.git works instead.

trmdi commented 7 years ago

@lipido

  1. Could you give an option to display Run/Go button or display just a hover effect like the Share button, or even no effect at all.
  2. It would be more flexible if the tooltip could be changed, for example users could hover over the time icon to see the date, no need to click to display the submenu, it is similar to the default Time date widget.
lipido commented 7 years ago

@trmdi Could you please open different issues with those ideas to keep this more organized?

trmdi commented 7 years ago

Ok, I did that. Please go to https://github.com/lipido/kargos/issues/2