search

lipinskipawel / football-game-engine

Engine for 2D football game
MIT License
1 stars 0 forks source link

Add support for saving neural network on disk #8

Closed lipinskipawel closed 4 years ago

lipinskipawel commented 5 years ago

It can be saved on a text file. The proper format should look like that: <type of neural network> <layer weights>:<layer biases>:<layer activation function> <second layer>...<> <...> . . <last layer>....<>

PatrykMilewski commented 5 years ago

Maybe we should write it as YAML? Just suggestion

lipinskipawel commented 5 years ago

I see your idea, but generally, I would like to store this in binary format and eventually expose an API that can in an efficient way fetch all data. The only reason why we should store this in YAML file is the readability of that format, am I right?

lipinskipawel commented 5 years ago

But on the other hand, if you are going to pick this issue, implement this as you want. The API will evolve anyway as this is the nature of all projects.

PatrykMilewski commented 5 years ago

Yeah, I thought it would be more readable

On 27 Sep 2019, at 15:53, Paweł Lipiński notifications@github.com wrote:

I see your idea, but generally, I would like to store this in binary format and eventually expose an API that can in an efficient way fetch all data. The only reason why we should store this in YAML file is the readability of that format, am I right?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lipinskipawel/game-engine/issues/8?email_source=notifications&email_token=AFBKVTCKVTB4JEY2PNNMHVLQLYF4FA5CNFSM4I3GUXZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7Y64II#issuecomment-535948833, or mute the thread https://github.com/notifications/unsubscribe-auth/AFBKVTENBOABTTB4DJPPC73QLYF4FANCNFSM4I3GUXZQ.

PatrykMilewski commented 5 years ago

@lipinskipawel I will pick up this one, but not this weekend, maybe in next week I will manage to find some time for this 😄 Should be easy to implement

lipinskipawel commented 5 years ago

Sure, thanks :) Can you assign this issue to yourself then?

lipinskipawel commented 4 years ago

Closing the issue of inactivity. Clients can use alternative https://github.com/lipinskipawel/game-engine/blob/master/game-engine/src/main/java/com/github/lipinskipawel/board/ai/ml/NeuralNetwork.java#L22