Branch that supersedes previous PRs

liquigraph / sentinel

Apache License 2.0

0 stars 2 forks source link

Branch that supersedes previous PRs #6

Closed fbiville closed 6 years ago

fbiville commented 6 years ago

cc @badrfoot (I could not tag you in the commit without your email address) I added a quick'n'dirty improvement to the main function with coroutines

I think there are still bugs in the current YAML update function (run the main method to see):

additions are not added in ascending order
updates are not inserted

fbiville commented 6 years ago

@badrfoot If you're still motivated, I've added two failing assertions to fix before this PR can be merged SentinelRunner is much more readable now, should be easier to debug if needs be

Once this PR is complete, https://github.com/fbiville/sentinel/issues/2 will finally be able to start

oussamabadr commented 6 years ago

OK @fbiville, I will take a look and try to PR by the end of this week.