search

liran-funaro / sphinx-markdown-builder

A Sphinx extension to add markdown generation support.
https://pypi.org/project/sphinx-markdown-builder
MIT License
32 stars 14 forks source link

Update test with corner case for table #4

Closed flynneva closed 10 months ago

flynneva commented 11 months ago

@liran-funaro I believe this is what #3 is about.

Let me know if you have any questions

flynneva commented 11 months ago

I guess maybe not since the test is passing already...let me keep digging

liran-funaro commented 11 months ago

@flynneva Thank you for taking the time to investigate this issue.

I still don't see the error that was described on #3 when testing with your modifications.

Please note that the last change breaks other tests, so I suggest removing it from this PR.

Maybe you are running on a different version of sphinx? Can you share your version?

liran-funaro commented 10 months ago

@flynneva The changes you made in ExampleRSTFile.rst and ExampleRSTFile.md does not fail the test on the main branch on my local machine and in the CI. Something in your environment may be different. We should find out what it is in order to resolve this bug.

flynneva commented 10 months ago

@liran-funaro no worries. I'm circling back to this today so ill try and update this PR either today or over the weekend 👍🏼