search

lisamelton / video_transcoding

Tools to transcode, inspect and convert videos.
MIT License
2.39k stars 160 forks source link

Add one liner for batch transcoding a folder #242

Closed iainsmith closed 5 years ago

iainsmith commented 5 years ago

Hi @donmelton,

First, thanks for sharing your transcoding scripts 👍.

I was running some tests and wanted a quick way to transcode a folder of videos to test various setting combinations. This one liner was useful to me and so I thought it might be helpful to others. If you'd rather discourage this usage, feel free to close this and move on. Hopefully catch you for a 🍷 / 🍺 sometime.

lisamelton commented 5 years ago

@iainsmith Thanks for the patch! I'll take a closer look soon. Although I'm not sure this is necessary since you can pass multiple file inputs to transcode-video already.

lisamelton commented 5 years ago

@iainsmith Sorry I took so long to give you the final answer of this one, but I've decided not to add this to the README document. Again, it's because it's already possible to pass multiple file inputs and I don't want to confuse users.

But, please, don't let this rejection deter you from submitting other thoughtful patches! Keep them coming and keep us all thinking.

Thanks, again!