search

lisamelton / video_transcoding

Tools to transcode, inspect and convert videos.
MIT License
2.39k stars 160 forks source link

Add fallback-crop minimal documentation to ReadMe section of detect-crop #266

Closed JMoVS closed 5 years ago

JMoVS commented 5 years ago

As some people might still use detect-crop separately, I'm assuming they might also want to know the "minimal" option of the detect-crop facilities added to the Readme. So as referenced, I'm opening this issue now.

_Originally posted by @donmelton in https://github.com/donmelton/video_transcoding/issues/255#issuecomment-468838581_

lisamelton commented 5 years ago

@JMoVS Thanks! I'll draft something today.

lisamelton commented 5 years ago

@JMoVS OK, how does this read as an addition to the "Cropping" section of the "README" document after mentioning that --crop detect can fail?

Which is why you can select a fallback behavior using the --fallback-crop option when that happens, choosing handbrake, ffmpeg, minimal or none as its argument:

transcode-video --crop detect --fallback-crop minimal "/path/to/Movie.mkv"

The minimal argument is perhaps the most useful behavior since it determines the smallest possible crop values by combining results from both HandBrakeCLI and ffmpeg.

JMoVS commented 5 years ago

if it were for british spelling, I'd write "behaviour" but aside from that, 👍

lisamelton commented 5 years ago

@JMoVS OK, that live in the "README" now. Thanks, again!

platonium commented 5 years ago

Dear Don and the Transcode Gang,

Thank you so much for minimal and your hard work.

Best, Plato

Sent from my iPhone

On Mar 4, 2019, at 2:04 PM, Don Melton notifications@github.com<mailto:notifications@github.com> wrote:

Closed #266https://github.com/donmelton/video_transcoding/issues/266.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/donmelton/video_transcoding/issues/266#event-2179247808, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOepbeU0IYE7uo596hHkQyiFpQrY6L8eks5vTZhjgaJpZM4bbxru.

lisamelton commented 5 years ago

@platonium You are very welcome! I'm glad you like it.