search

lishen2 / isotp-c

An implementation of the ISO-TP (ISO15765-2) CAN protocol in C
MIT License
212 stars 79 forks source link

Struct parameter receive_arbitration_id is never used #18

Closed jnz86 closed 2 years ago

jnz86 commented 4 years ago

I think the intention was probably to match up a on_can_receive id with the receive_arbitration_id, but it seems instead you just trust that the user didn't call on_can_receive feeding in the wrong can message to the wrong associated link.

So at least a comment saying THIS IS UNUSED would be good if not the 4 bytes removed from the structure entirely.

LINE 43 isotp.h

lishen2 commented 2 years ago

This variable is prepared for upper-layer protocols, such as UDS, sorry to confuse you.