lishen2 / isotp-c

An implementation of the ISO-TP (ISO15765-2) CAN protocol in C
MIT License
212 stars 79 forks source link

Bug & Typo Fixes #2

Closed SimonCahill closed 5 years ago

SimonCahill commented 5 years ago

This pull requests fixes many typos in the repository, along with some bug fixes in the code itself.

All changes can be viewed in the individual commits.

The most important bug fix: In the function isotp_send_consecutive_frame() the variable data_length is too small. A uint8_t is used to contain the length of the frames. This bug causes frames larger than 256B to not be sent correctly. This bug was found by N. Bünder.

The fix is to replace the datatype with a 16-bit integer (uint16_t)