add calendar module - Githubissues

atowersc commented 3 years ago

the calendar module was added Seeks to obtain the complete economic calendar table for the week. https://finviz.com/calendar.ashx

List all economic activities by days. (complete table of the week)
verifies the impact of the economic result from 1 to 3 stars
get the assessment of the result. ( " > " better than expected) ( " < " less than expected)
verifier of which result is to come

Screenshot 2021-02-25 at 20

I hope it can be added to the master. since it is a good functionality. I am open to any criticism or suggestion.

lit26 commented 3 years ago

Looks good. I will check in these days.

lit26 commented 3 years ago

After reviewing the code, I decide not to merge the code into the master because of the following reason:

The coding style doesn't meet the expectation.
More information is given other than the information from the website.
The data frame should be easy for further processing, not just scrap the information from the website. You can still change the file. Thank you for helping with this repository.

lit26 / finvizfinance