search

liuis / leveldb

Automatically exported from code.google.com/p/leveldb
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Clarification on the scratch parameter in SequestialFile::Read(size_t n, Slice* result, char* scratch) = 0; #37

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I read the source code implementation and find the "scratch" content must be 
valid when the "result" is used.
I would suggest to add a comment on that, since that's not quite 
straightforward to be understood in the first place.
Also apply to RandomAccessFile::Read(....)

Thanks

Original issue reported on code.google.com by tianzhou...@gmail.com on 28 Aug 2011 at 1:02

GoogleCodeExporter commented 9 years ago 
Fixed in revision 299ccedfeca1.

Thanks for pointing this out!

Original comment by ga...@google.com on 5 Oct 2011 at 11:32