search

liujianguang / embeddedjavascript

Automatically exported from code.google.com/p/embeddedjavascript
Other
0 stars 0 forks source link

String.prototype monkeypatching #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
rsplit and chop are unnecessary additions to String.prototype, considering
they are only used a combined 3 times, and only within the library. Locally
scoped functions would suffice and would avoid modifications to the global
namespace (important when writing library code.) It seems these additions
are an artifact of the Ruby port, but are unnecessary and potentially
harmful here.

Patch is attached.

Original issue reported on code.google.com by Zack.Car...@gmail.com on 9 May 2009 at 11:23

Attachments:

GoogleCodeExporter commented 8 years ago 
The new version is coming out w/o this.

Original comment by JustinBMeyer@gmail.com on 28 Oct 2009 at 5:47

GoogleCodeExporter commented 8 years ago

Original comment by JustinBMeyer@gmail.com on 28 Oct 2009 at 5:47

GoogleCodeExporter commented 8 years ago 
Cool!

Original comment by Zack.Car...@gmail.com on 28 Oct 2009 at 6:01