search

liuzuxin / OSRL

🤖 Elegant implementations of offline safe RL algorithms in PyTorch
https://offline-saferl.org
Apache License 2.0
178 stars 12 forks source link

missing CORL citation #3

Closed Howuhh closed 1 year ago

Howuhh commented 1 year ago

Hi! Great work, surely, safety is a very important topic in offline RL. However, we are a little bit puzzled by the complete lack of citations for the CORL library, considering that:

  1. CORL is a library that is closer in spirit and implementation to OSRL, yet the article cites only d3rlpy. And more broadly, CORL is used in many papers and projects in offline RL, so we feel that a review of related work without mention of CORL is incomplete.
  2. CORL seems to have had a lot of influence on the design and code of this library, as one can find comments and code parts taken directly from CORL. For example, code on OSRL [1, 2] and exactly the same code in CORL [1, 2].

We would like to remind you that CORL is licensed under the Apache License. If you borrow code like this, you should give credit to the source. Also, such misconduct could actually be a significant violation of the NeurIPS Datasets and Benchmarks Track rules.

Thus, we would highly appreciate if you credited CORL both in the code and publication. Thanks in advance!

liuzuxin commented 1 year ago

Hi @Howuhh , thanks for pointing this out! We would like to express our sincerest apologies for the oversight. We indeed got a lot of inspiration from the amazing CORL library, both from the framework design and code implementation side. It was my mistake not to check the references and license carefully before releasing the code. We will add citations both in the paper and the code and the readme file. Thanks again for bringing this up at this early stage!

liuzuxin commented 1 year ago

Hi @Howuhh , we have just updated the license, README file, and updated references in the paper report. Note that the paper replacement will be announced online next Monday. You can preview it here. I will close this issue for now and feel free to reopen it if you have any other suggestions or comments, thanks!