search

livechat / chat-window-android

LiveChat mobile chat window for Android
https://developers.livechatinc.com/mobile/android/
MIT License
23 stars 28 forks source link

#34 fixed load error message issue #43

Open shanemckenzie opened 4 years ago

shanemckenzie commented 4 years ago

Switched the failed to load error to an alert, prevents the underlying ui from being interacted with while the alert is present and makes the error more readable

ZiggyKraus commented 3 years ago

Hello @shanemckenzie ,

Krzysztof here, from LiveChat's Technical Support. First of all, our apologies for reaching back to you with such a delay. I have spoken with a person who's handling the Android repository, and we will do our best to review the pull request as soon as possible. Currently, there are few things that we need to take care of in terms of our mobile apps as well, and as a lot of customers uses this repo, we will need to review your PR properly and accept it if possible.

In the meantime, we have got a suggestion: until we will review the PR, maybe you could fork the repo, implement your changes and then publish it (https://proandroiddev.com/android-libraries-on-github-packages-21f135188d58)? You could also implement the changes locally and use them in your project (https://medium.com/stantmob/how-to-use-android-libraries-locally-and-leaving-your-development-more-fast-47ef921c6dd9).

Once again, our apologies for the delay. We will do our best to take a look at it as soon as possible. In the meantime, please don't hesitate to ask in case of any additional questions or concerns.