App crashes during codepush update in android

[wjaykim]

Describe the bug

App crashes while applying codepush update in android. More specifically, after codepush finishes downloading new js bundle, app crashes while restarting to apply new js bundle.

It occured after https://github.com/livekit/client-sdk-react-native/commit/32cf80bad57c60eeabb257744945fb5dee18e715 commit; When I delete these lines, codepush works without crash.

To Reproduce

Steps to reproduce the behavior:

1. Apply codepush update(InstallMode.IMMEDIATE)

Expected behavior

App should not crash

Screenshots

Device Info:

• Device: All android devices
• OS: Android

Dependencies Info (please reference your package-lock.json or yarn.lock file):

• @livekit/react-native: 1.3.0
• livekit-client: 1.13.2
• react-native-webrtc: 104.0.1

Additional context

[wjaykim]

https://github.com/react-native-webrtc/react-native-webrtc/pull/1456

This issue can be fixed by above PR. Maybe livekit fork of react-native-webrtc needs to be updated as well.

[wjaykim]

PR I mentioned above is approved and about to be merged on next release. @davidliu Do you have any plans to make livekit/react-native-webrtc to be up-to-dated with origin repository or cherry-pick the commit?

[davidliu]

The plan is to periodically sync with the origin repo. I'll sync after the next release.

[davidliu]

livekit/react-native-webrtc is now synced to the upstream 111.0.6 release.