search

lizoc / textscript

Text templating powered by .NET
MIT License
5 stars 2 forks source link

Violation of license of scriban #3

Closed xoofx closed 5 years ago

xoofx commented 5 years ago

Hi, You are currently using the entire codebase of the scriban project https://github.com/lunet-io/scriban without retaining the original license which is violating its usage.

So please, I'm asking you to fix your license.

For guidance for your users, I would also appreciate that you specify that you are actually forking the original project scriban. Using a project like this (including the documentation) without properly giving back credits is really not the way to play respectfully in OSS world.

xoofx commented 5 years ago

Nevermind, I found the license in https://github.com/lizoc/textscript/blob/master/THIRD-PARTY-LICENSE.txt

xoofx commented 5 years ago

Reopening because you have been removing the license headers in the source files, while they should not be removed:

// Copyright (c) Alexandre Mutel. All rights reserved.
// Licensed under the BSD-Clause 2 license. 
// See license.txt file in the project root for full license information.

Please update your code base to reflect that this header should not be removed.

imacks commented 5 years ago

Hi there. Sorry if you feel violated, that was certainly not the intention. I've added your copyright header to all files that contained your code. Let me know if you are satisfied.

If you would like more credit exposure beyond that and the third party license doc, I can also add something at the top of the readme, along the lines of "this project is adopted from scriban etc..". If you have wording in mind just let me know too.

FYI, numerous breaking changes are made and will be made here for my specific needs, things you probably would not care to consider in your project. That's why this is a hard fork that's expected to diverge from your code base in time. However, I have a fork on your repo too, and I do hope you are still cool if I make any PRs to your scriban project in the future based on that?

xoofx commented 5 years ago

If you would like more credit exposure beyond that and the third party license doc, I can also add something at the top of the readme, along the lines of "this project is adopted from scriban etc..". If you have wording in mind just let me know too.

I would prefer that instead of listing scriban as part of the "We take inspirations from the following repos" you should separate it from the rest of this list (frankly, this is not just "inspiration" in the case of scriban) and explicit that TextScript is a fork of scriban, and explaining why. It will provide better guidance and avoid confusion.

imacks commented 5 years ago

As I said

I can also add something at the top of the readme, along the lines of "this project is adopted from scriban etc.."

I have decided to add a big banner at the top of the readme that says this is a fork from your repo. I'll let you know once that's done, probably after new year.

imacks commented 5 years ago

Honestly, it was a oversight on my part to remove the header copyright notice, but that has since been fixed in the previous commit. I hope that means it's all good legally.

Coupled with the fork clarification I just said, I trust you have nothing to add?

xoofx commented 5 years ago

Coupled with the fork clarification I just said, I trust you have nothing to add?

No that should be fine, thanks.

imacks commented 5 years ago

closing for now. feel free to open again if you are still having issues.