search

ljharb / es-abstract

ECMAScript spec abstract operations.
MIT License
114 stars 30 forks source link

callBind - fix bug where callBind.apply is overwritten #113

Closed kumavis closed 4 years ago

kumavis commented 4 years ago

Fixes https://github.com/ljharb/es-abstract/issues/112

kumavis commented 4 years ago

as far as i can tell, this doesn't affect the package's explicit exported interfaces, and so should not be a breaking change

kumavis commented 4 years ago

i like the approach of adding real ses better : ) but it has pointed out some additional issues

ljharb commented 4 years ago

That's ok, we can fix all those things :-)

kumavis commented 4 years ago

@ljharb working on a fix for object.assign right now

ljharb commented 4 years ago

It looks like the linter is the only failure.

kumavis commented 4 years ago

this should be the object.assign issue https://github.com/ljharb/object.assign/pull/77

ljharb commented 4 years ago

object.assign v4.1.1 is released

ljharb commented 4 years ago

Just the codecov status. I'm looking into it.

(however I'm still concerned about https://github.com/ljharb/object.assign/issues/79)

kumavis commented 4 years ago

noting that Function.prototype.apply can not be assigned to in ses v0.7.x but can be assigned to in ses v0.10.x