search

ljharb / es-abstract

ECMAScript spec abstract operations.
MIT License
114 stars 30 forks source link

Data files in `operations` folder are missing from v1.14 onwards #62

Closed ExE-Boss closed 5 years ago

ExE-Boss commented 5 years ago

This is a breaking change, since everything reachable is part of the public API.

I recommend keeping the 2015.js, 2016.js, 2017.js, 2018.js and 2019.js files, which export useful data.

ljharb commented 5 years ago

That is true; the data was only intended for use by tests.

Other than your types PR, are you aware of anyone using the data? I’d prefer to consider it a bug that they were ever included, and I’d sooner bump to v2 than re-include them.

ljharb commented 5 years ago

Closing, pending more info.

ExE-Boss commented 5 years ago

Well, since you want to bump to v2 anyway, you should include the breaking changes from #67 and #68 with it.

ljharb commented 5 years ago

hmm, I'm actually confused. I npmignored the js files in operations/, not the json files. Those should be included still.

ljharb commented 5 years ago

ah lol they're all JS files. I think I intended to only block the scripts, not the data.