search

ljharb / es-abstract

ECMAScript spec abstract operations.
MIT License
114 stars 30 forks source link

[Breaking] `ES2018+`: `GetIterator`, `IterableToList`, `IteratorNext`, `IteratorStep`, `IteratorClose`: use iterator records instead #68

Open ExE-Boss opened 5 years ago

ExE-Boss commented 5 years ago

Depends on:

BREAKING CHANGE: This is backwards incompatible, as ES2017 and older operated directly on the Iterator instance.

codecov[bot] commented 5 years ago

Codecov Report

Merging #68 into master will decrease coverage by 0.94%. The diff coverage is 55.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   90.89%   89.94%   -0.95%     
==========================================
  Files         670       31     -639     
  Lines        9444     1781    -7663     
  Branches     2195      554    -1641     
==========================================
- Hits         8584     1602    -6982     
+ Misses        860      179     -681
Impacted Files Coverage Δ
es2018.js 82.11% <55.93%> (-17.89%) :arrow_down:
es2019.js 88.23% <0.00%> (-11.77%) :arrow_down:
es2015.js 88.95% <0.00%> (-11.05%) :arrow_down:
es5.js 91.48% <0.00%> (-8.52%) :arrow_down:
es2016.js 92.68% <0.00%> (-7.32%) :arrow_down:
helpers/getSymbolDescription.js 93.75% <0.00%> (-6.25%) :arrow_down:
es2017.js 95.65% <0.00%> (-4.35%) :arrow_down:
helpers/mod.js 100.00% <0.00%> (ø)
helpers/getIteratorMethod.js 100.00% <0.00%> (ø)
... and 640 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e8d479...cc8ca78. Read the comment docs.

ljharb commented 4 years ago

I rebased #67 but i think this one I'll leave to you :-)