search

ljharb / es-abstract

ECMAScript spec abstract operations.
MIT License
114 stars 30 forks source link

[Fix] `ES5+`: Use spec‑accurate `IsCallable` #93

Open ExE-Boss opened 4 years ago

ExE-Boss commented 4 years ago

The IsConstructor implementation is based on the one in https://github.com/tc39/ecma262/issues/1798#issuecomment-559914634

Fixes https://github.com/ljharb/es-abstract/issues/48

codecov[bot] commented 4 years ago

Codecov Report

Merging #93 into master will increase coverage by 0.09%. The diff coverage is 96.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   90.90%   91.00%   +0.09%     
==========================================
  Files         647      647              
  Lines        8961     9071     +110     
  Branches     2120     2137      +17     
==========================================
+ Hits         8146     8255     +109     
- Misses        815      816       +1
Impacted Files Coverage Δ
2015/IsConstructor.js 94.44% <94.44%> (-5.56%) :arrow_down:
2016/IsConstructor.js 94.44% <94.44%> (-5.56%) :arrow_down:
2017/IsConstructor.js 94.44% <94.44%> (-5.56%) :arrow_down:
2018/IsConstructor.js 94.44% <94.44%> (-5.56%) :arrow_down:
2019/IsConstructor.js 94.44% <94.44%> (-5.56%) :arrow_down:
2015/IsCallable.js 100.00% <100.00%> (ø)
2016/IsCallable.js 100.00% <100.00%> (ø)
2017/IsCallable.js 100.00% <100.00%> (ø)
2018/IsCallable.js 100.00% <100.00%> (ø)
2019/IsCallable.js 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d959e6d...a0dc7e0. Read the comment docs.

ljharb commented 4 years ago

I've separated out the IsConstructor fixes and pulled those into master; this PR has been rebased with just the IsCallable changes.