search

ljosberinn / keystone-heroes

Keystone Heroes provides in-depth analysis for Mythic+ runs based on Warcraft Logs including routes, cooldown usage and other improvement vectors.
https://keystone-heroes.com/
15 stars 3 forks source link

include player pets into damage done aggregates where necessary #31

Open ljosberinn opened 3 years ago

ljosberinn commented 3 years ago

e.g. getDamageDoneToManifestationOfPrideEvents groups units such as treants, frothing postule, greater earth elemental as separate player. to include their damage done, we'd have to link them to the player.

if we're planning to show damage aggregates per class per pride or something, this results in mildly invalid numbers and - worse - redundant data in the db. getDamageDoneToManifestationOfPrideEvents is a non issue however since the events arent currently stored, but immediately used.

ljosberinn commented 3 years ago

since Prideful season is basically over, above is a bad example. However its notable when e.g. hunters kill Explosive Orbs with Kill Command or the pet uses Claw - these kills should be attributed to the pet owner, right now they get lost.