search

ljosberinn / keystone-heroes

Keystone Heroes provides in-depth analysis for Mythic+ runs based on Warcraft Logs including routes, cooldown usage and other improvement vectors.
https://keystone-heroes.com/
15 stars 3 forks source link

[Bug]: TypeError Reduce of empty array with no initial value #84

Closed ljosberinn closed 2 years ago

ljosberinn commented 2 years ago

Which route is the error occuring on?

Steps to Reproduce

./src/wcl/queries/events/affixes/bolstering.ts in getHighestBolsteringStack at line 73:37

reportID nH7q6yX2R9WjxAT4 fight 97

ljosberinn commented 2 years ago

fixed in 45a6ba28bf8019a89a38877121a36ccd696a650d

however, this is technically caused by an underlying, rare-to-trigger bug:

every fight is attached to a report every report has a week

however, if the report contains fights from two weeks, the later fights will check affix events based on the previous weeks' affixes

this could be fixed by moving the week property to fight.. but its such a rare case anyways.