lkaric / nestjs-twilio

Injectable Twilio client for Nestjs.
https://www.npmjs.com/package/nestjs-twilio
MIT License
42 stars 10 forks source link

Add renovate and update deps #46

Closed luluhoc closed 1 year ago

luluhoc commented 1 year ago

What

What changes are being made? (e.g. feature, bug, docs etc.) Update deps

Why

Why are these changes necessary? yes

How

How were these changes implemented?

Checklist

Have you done all of these things?

luluhoc commented 1 year ago

@rejvban

lkaric commented 1 year ago

Considering that you bumped up the node, I'd really like it if you also appropriately changed the versions through the workflows and related names (examples below). Otherwise, everything seems fine 👍

https://github.com/rejvban/nestjs-twilio/blob/4ce38adff7d9064044a05304e11b3fcd320dc541/.github/workflows/build.yml#L14

https://github.com/rejvban/nestjs-twilio/blob/4ce38adff7d9064044a05304e11b3fcd320dc541/.github/workflows/build.yml#L17

luluhoc commented 1 year ago

Considering that you bumped up the node, I'd really like it if you also appropriately changed the versions through the workflows and related names (examples below). Otherwise, everything seems fine 👍

https://github.com/rejvban/nestjs-twilio/blob/4ce38adff7d9064044a05304e11b3fcd320dc541/.github/workflows/build.yml#L14

https://github.com/rejvban/nestjs-twilio/blob/4ce38adff7d9064044a05304e11b3fcd320dc541/.github/workflows/build.yml#L17

Done :)