search

lkerr / groundfish-MSE

Development of Robust Management Strategies for Northeast Groundfish Fisheries in a Changing Climate
MIT License
4 stars 2 forks source link

Econ only2 #224

Closed mle2718 closed 2 years ago

mle2718 commented 2 years ago

So many changes.

  1. "Data" changes in the /data folders fix some bugs in the coding of some stocks (mult allocated and non-allocated) for quota monitoring purposes. Add results of the economic model estimated by @abirken and preliminary quota price model by Lee and Demarest.
  2. Update economic functions.

Most changes are just economic functions or processes, but please pay special attention to changes to:

functions/assessment/get_ASAP.R processes/get_runinfo.R processes/runSetup.R processes/runSim.R

These largely incorporates features from PR #209, because I needed to get the changes from the ml_asap branch into the EconOnly2 branch to get it to run.

jerellejesse commented 2 years ago

@mle2718 I am going through this now, but I have never run a branch with the updated economic component and I am getting an error. I have ImplementationClass set to StandardFisheries, but getting: Error in if (mproc$ImplementationClass[m] == "Economic") { : missing value where TRUE/FALSE needed. Is there anything you think might be happening? Maybe it's just user error on my side!

mle2718 commented 2 years ago

@jerellejesse: it's because my crappy code had this:

mproc<-mproc_bak[2:2,]

when it should have had this:

 mproc<-mproc_bak[1:1,]

for testing. I just fixed it, so if you re-pull, you should get past that error message.