Open CircleD5 opened 6 months ago
I have some concerns regarding the code found.
In networks.py, the function list_available_networks() registers the file name as the Key in available_network_aliases. On the other hand, it registers entry.alias as the Key in available_network_aliases, which essentially means using the model's ss_output_name as the Key.
This implies that Lora models that have been renamed (where the ss_output_name and file name do not match) cannot be loaded.
Shouldn't we register entry.alias as the Key in available_network_aliases instead of the file name to align with Automatic1111 Webui?
I'm assuming changing the "refer to lora by" option from Filename to Alias from file is not a vialble workaround, nor is renaming the lora safetensor file itself? If I understand correctly, that is.
Much like your lora, it seems you found a part of the code that's a bit of a mess
Thank you! I wasn't aware of the "refer to lora by" option. After changing this option from 'Alias from file' to 'Filename', it started working properly.
Therefore, my problem is solved by changing the "refer to lora by" option from 'Alias from file' to 'Filename'.
However, while in the Automatic1111 WebUI, it works correctly with 'Alias from file', in the WebUI Forge, it does not work with 'Alias from file'. I am unable to determine whether this is a feature (i.e., intentional behavior) or a bug. I would like to leave the decision of whether to close this issue or keep it open to the code administrators or a third party who understands this code.
Just to add another anecdotal data point. I also ran into this issue, and switched to "refer to by lora by filename" under the "Extra Networks tab". Re-running my job, I received a similar but slightly different error, when I realized that I was also missing one of the LORA models I was attempting to reference (typo in name). A1111 would usually throw a "referenced lora 'abcd' not found, skipping " error in these situations. Remedied that issue and now everything is working great!
Checklist
What happened?
Encountered a bug where a specific Lora does not load when attempting to insert it through the Lora tab in the WebUI Forge. Interestingly, it works with Automatic1111's WebUI.
Error Message
Steps to reproduce the problem
The problematic Lora can be found at the following URL. Please note, this is an NSFW Lora, so proceed with caution. https://civitai.com/models/319572?modelVersionId=358351
What should have happened?
When selecting the mentioned Lora in the Lora tab of the browser-based WebUI, it should correctly insert into the prompt and be utilized for generation.
What browsers do you use to access the UI ?
Microsoft Edge
Console logs
Additional information
Upon further investigation, I discovered an issue highlighted in the load_networks function
When clicking on the relevant Lora in the Lora tab within the WebUI browser, is inserted. However, the correct name should be 'cumbaXLP_vertical', indicating that an incorrect value is being inserted.
Interestingly, this incorrect value 'cumbaXLP_vertical' is included as a Key in available_networks used within load_networks() but not in available_network_aliases.
Suggested Solution
We should correct the behavior so that when clicking on a specific Lora in the Lora tab within the WebUI Forge, the incorrect name (file name) is not inserted. Instead, inserting the exact value 'cumbaXLP_vertical' directly (bypassing the WebUI) results in the correct functionality.