search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
29.24k stars 12.07k forks source link

`performance-unnecessary-value-param` does not support adding allowed types that are template parameters #113210

Open carlosgalvezp opened 1 month ago

carlosgalvezp commented 1 month ago

I am having the same issue as here: https://github.com/llvm/llvm-project/issues/101181

I try to fix it by adding:

  performance-unnecessary-value-param.AllowedTypes: 'Iterator'

To my .clang-tidy file, but it doesn't work. Probably because clang-tidy is matching that against "the real type" instead of the "written" type.

llvmbot commented 1 month ago

@llvm/issue-subscribers-clang-tidy

Author: Carlos Galvez (carlosgalvezp)

I am having the same issue as here: https://github.com/llvm/llvm-project/issues/101181 I try to fix it by adding: ``` performance-unnecessary-value-param.AllowedTypes: 'Iterator' ``` To my `.clang-tidy` file, but it doesn't work. Probably because clang-tidy is matching that against "the real type" instead of the "written" type.