Open banach-space opened 1 year ago
@llvm/issue-subscribers-mlir-sparse
Apologies, I forgot to update this with the progress so far.
The most natural way to remove duplication would be to replace lli
with mlir-cpu-runner
and to fold the two RUN
lines listed above into 1.
-mattr
and -march
to -mlir-cpu-runner
so that there's no need to use lli
instead of mlir-cpu-runner
: https://reviews.llvm.org/D146917 ✅ RUN
lines into one: https://reviews.llvm.org/D148005.The 2nd patch is still under review.
When extending SparseCompiler integrations tests to run via SVE codegen (see https://reviews.llvm.org/D143514 and https://reviews.llvm.org/D121304), we effectively duplicated many of the RUN lines.
More specifically, if the
MLIR_RUN_ARM_SVE_TESTS
CMake flag is disabled, the following RUN lines are effectively identical (they verify similar code-path):We should avoid this. My suggestion would be to replace both
RUN
lines with RUN line 2. above. Additionally, we should make sure that there are public buildbots thatOn
(e.g. clang-aarch64-sve-vlaOff
(that's the default, so any buildbot running MLIR integration tests should be fine, e.g. mlir-rocm-mi200This way we will be making sure that all configurations are tested, but there is not code duplication in tests. WDYT?
CC @aartbik
-Andrzej