lmcinnes / umap

Uniform Manifold Approximation and Projection
BSD 3-Clause "New" or "Revised" License
7.49k stars 809 forks source link

bokeh.plotting.helpers is gone in bokeh 2.0 #375

Open arnicas opened 4 years ago

arnicas commented 4 years ago

Seems like they removed the entire bokeh.plotting.helpers in 2.0 release of bokeh, which causes an error in some interactive plotting that needs holoviews. Might want to pin it in the requirements to 1.4? (Great work on all the new vis options, by the way!)

lmcinnes commented 4 years ago

Thanks for the feedback -- it means a lot to get positive feedback on visualizations from you! I'll pin bokeh for now. Is holoviews broken in general for bokeh 2.0? This looks like an annoying issue to work through. I'll have to see what I can do.

andreaswachowski commented 4 years ago

Is holoviews broken in general for bokeh 2.0?

Looks like it, see https://github.com/holoviz/holoviews/issues/4293

philippjfr commented 4 years ago

Now fixed, I've released HoloViews 1.13.0 which does support Bokeh 2.0.

philippjfr commented 4 years ago

Also sorry about the delay here, we were hoping to have a release in time for bokeh 2.0 but it just didn't happen. Ideally we would have pinned older packages appropriately but updating all old releases with the appropriate pins was not feasible.

lmcinnes commented 4 years ago

Thanks @philippjfr ! Glad to hear it got resolved.