lmnr-ai / lmnr

Laminar - open-source all-in-one platform for engineering AI products. Crate data flywheel for you AI app. Traces, Evals, Datasets, Labels. YC S24.
https://www.lmnr.ai
Apache License 2.0
1.18k stars 59 forks source link

fix page number updated to 0 when changing filter and updated custom … #208

Closed sarthakvijayvargiya closed 2 weeks ago

sarthakvijayvargiya commented 2 weeks ago

fix #150

https://github.com/user-attachments/assets/8417d67e-f3bb-4d7e-969f-179c2c1083e1


[!IMPORTANT] Reset pageNumber to 0 when changing filters in date-range-filter.tsx.

  • Behavior:
    • Reset pageNumber to 0 when changing filters in AbsoluteDateRangeFilter and DateRangeFilter.
    • Specifically, reset pageNumber when setting startDate, endDate, or pastHours.
  • Files:
    • Modifications in date-range-filter.tsx to handle pageNumber reset logic.

This description was created by Ellipsis for ace20664382df333da27c6206224b9dffbd3b141. It will automatically update as commits are pushed.

CLAassistant commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

sarthakvijayvargiya commented 2 weeks ago

Hi @dinmukhamedm Let me know if this good to go? or needed some change

dinmukhamedm commented 2 weeks ago

This is good to go, thanks. Merging this into dev