search

lni / dragonboat

A feature complete and high performance multi-group Raft library in Go.
Apache License 2.0
5.06k stars 541 forks source link

mod: bump dragonboat to pebble 1.0.0 #341

Open coufalja opened 8 months ago

coufalja commented 8 months ago

This is based off work of @tylerwilliams in https://github.com/lni/dragonboat/pull/339 as I am eagerly waiting for this to be merged, I took the liberty to rebase the PR and open it again.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1d6e2d7) 84.49% compared to head (ad763cb) 84.44%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #341 +/- ## ========================================== - Coverage 84.49% 84.44% -0.04% ========================================== Files 10 10 Lines 4280 4280 ========================================== - Hits 3616 3614 -2 - Misses 406 407 +1 - Partials 258 259 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coufalja commented 8 months ago

@lni What about the staticcheck errors should I fix them as well (they seem all to be related to bump of Go version rather than to core of this PR)

tylerwilliams commented 8 months ago

@coufalja thanks for picking this up :)

coufalja commented 8 months ago

I have fixed the static-check issues in a separate commit.

coufalja commented 8 months ago

@lni Any feedback?

coufalja commented 7 months ago

It looks that meanwhile 1.1.0 was published, should I update this? It again breaks the lni/vfs so we will need to go through the full loop again.