search

lob / lob-typescript-sdk

MIT License
10 stars 7 forks source link

Properties missing on the Letter class #235

Closed dpaladin closed 1 year ago

dpaladin commented 1 year ago

Summary

There are properties missing in the create letter response (Letter class), in this case i need url

Expected Behavior

All properties specified in https://docs.lob.com/#tag/Letters/operation/letter_create should be included

Current Behavior

There is no url in the response object.

Possible Solution

Add the missing field(s)

Context (Environment)

Using version 1.0, url is one of the few properties i need, the old sdk did work properly

BennyKitchell commented 1 year ago

Hey @dpaladin

Thanks for bringing this to our attention, I am going to take a look into this and let you know a time frame in the next few days.

BennyKitchell commented 1 year ago

@dpaladin I have added the url into the Letter response, it will be out in the next release which will be by end of the week.

BennyKitchell commented 1 year ago

@dpaladin The new version of the typescript sdk can be found via npm or directly here. It now includes the url in the Letter response. I will leave this issue open for a few days to give you a chance to verify. Thanks!