localgovdrupal / localgov_menu_link_group

Present menu links in groups.
0 stars 0 forks source link

Fix remaining strict types errors #34

Closed millnut closed 3 weeks ago

millnut commented 8 months ago

With Drupal core moving towards strict types, more info we should fix the remaining errors suppressed in the phpstan baseline.

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_menu_link_group/localgov_menu_link_group.module
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  91     Parameter #2 $callback of function array_walk expects callable(Drupal\Core\Entity\EntityInterface, int|string): mixed, array{Drupal\localgov_menu_link_group\MenuLinkGrouper, 'groupChildMenuLinks'} given.
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_menu_link_group/src/Controller/LocalGovMenuLinkGroupListBuilder.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  51     Parameter #1 $group of method Drupal\localgov_menu_link_group\Controller\LocalGovMenuLinkGroupListBuilder::determineParentMenuLinkLabel() expects Drupal\localgov_menu_link_group\Entity\LocalGovMenuLinkGroupInterface,
         Drupal\Core\Entity\EntityInterface given.
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_menu_link_group/src/Form/LocalGovMenuLinkGroupForm.php
 ------ ------------------------------------------------------------------------------------------------------------------------
  80     Dynamic call to static method Drupal\localgov_menu_link_group\Form\LocalGovMenuLinkGroupForm::prepareMenuLinkOption().
 ------ ------------------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------
  Line   modules/contrib/localgov_menu_link_group/tests/src/Kernel/GroupAccessTest.php
 ------ -------------------------------------------------------------------------------
  64     Class DOMXPath referenced with incorrect case: DomXPath.
  79     Class DOMXPath referenced with incorrect case: DomXPath.
 ------ -------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_menu_link_group/tests/src/Kernel/GroupConfigImportTest.php
 ------ -------------------------------------------------------------------------------------
  45     Call to function in_array() requires parameter #3 to be set.
  72     Call to function in_array() requires parameter #3 to be set.
 ------ -------------------------------------------------------------------------------------