locusrobotics / fuse

The fuse stack provides a general architecture for performing sensor fusion live on a robot. Some possible applications include state estimation, localization, mapping, and calibration.
Other
732 stars 123 forks source link

fuse -> ROS 2 fuse_core: Fix Async (Redux) #294

Closed sloretz closed 1 year ago

sloretz commented 1 year ago

@methylDragon Here's an alternative to #293. I'm running the test_async_sensor_model test locally with --retest-until-fail 1000. I think this addresses the two issues found so far.

@svwilliams for visibility

methylDragon commented 1 year ago

I've updated the PR to include the following changes:

We uncovered a potential bug in rclcpp's executors' handling of mutually exclusive callback groups, but in this case it doesn't block the progress for fuse_core

methylDragon commented 1 year ago

See: https://github.com/locusrobotics/fuse/issues/276

sloretz commented 1 year ago

I made a few changes after self-reviewing and reading this bit of fuse_tutorials.

sloretz commented 1 year ago

@ros-pull-request-builder retest this please

methylDragon commented 1 year ago

@ros-pull-request-builder retest this please

sloretz commented 1 year ago

Let's add an initialized_ = false in the internal stops

Added in 9c95cf6

sloretz commented 1 year ago

@ros-pull-request-builder retest this please