search

loft-br / xgboost-survival-embeddings

Improving XGBoost survival analysis with embeddings and debiased estimators
https://loft-br.github.io/xgboost-survival-embeddings/
Apache License 2.0
321 stars 53 forks source link

BootstrapEstimator is actually BaggingEstimator #55

Open BardiaKh opened 2 years ago

BardiaKh commented 2 years ago

The BootstrapEstimator is actually training n models each with different fraction of the data. The reported CI is not the bootstrapped CI.

As this is bagging and I suggest renaming the class to avoid confusions especially in the academic settings.

davivieirab commented 2 years ago

Thanks for the report @BardiaKh !