search

loft-sh / vcluster-docs

https://vcluster.com/docs
Apache License 2.0
5 stars 27 forks source link

Hooks pro pods add image pull secrets #338

Closed kmadel closed 4 days ago

kmadel commented 1 month ago

Although the vCluster vcluster.yaml configuration provides the workloadServiceAccount that allows including imagePullSecrets, it is limited as that serviceAccount is superseded when using sync.toHost.pods.serviceAccounts.enabled: true.

This allows setting imagePullSecrets at the pod level instead of via a serviceAccount - although it does rely on a Pro feature.

netlify[bot] commented 1 month ago

Deploy Preview for vcluster-docs-site ready!

Built without sensitive environment variables

Name Link
Latest commit 0a85558c8da5cdc484aba95bf371150fa55baa47
Latest deploy log https://app.netlify.com/sites/vcluster-docs-site/deploys/672e80f5db48af00081662f6
Deploy Preview https://deploy-preview-338--vcluster-docs-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Piotr1215 commented 3 weeks ago

Could you please allow edits by maintainers, so I can help you with vale?

kmadel commented 3 weeks ago

The Vale issue is related to using "Hooks (Pro)". I believe we use this formatting in multiple places. If we are going to change it to satisfy Vale, what should it be changed to? "Hooks (pro)"? Also, can't add comment in source as this Vale issue is for something that was not changed in the PR.

Piotr1215 commented 2 weeks ago

@kmadel, apologies for back and forth on this one, I had to add the vale exception in different file. If you rebase again the rule should work correctly.