search

logstash-plugins / logstash-filter-cipher

Apache License 2.0
4 stars 28 forks source link

Logstash 5.x compatible #18

Closed vktor18 closed 7 years ago

vktor18 commented 7 years ago

fixed mutex from #11 and added support for Logstash 5.x

wiibaa commented 7 years ago

@vktor18 to properly run the travis build, you must update the travis.yml to match what is done in other plugin https://github.com/logstash-plugins/logstash-filter-grok/blob/master/.travis.yml mainly forcing jdk8 is key

vktor18 commented 7 years ago

I have no idea why travis is angry with me.... Did I push incorrect changes for the travis.yml?

wiibaa commented 7 years ago

Now the travis build is ok, but the spec is failing

ph commented 7 years ago

@vktor18 This seems to be a real error.

1) LogStash::Filters::Cipher 1000 events, 11 re-use, encrypt/decrypt aes-128-cbc, 16b RANDOM IV, 16b key, b64 encode validate encrypted message is not equal to message
     Failure/Error: expect(result.get("message")).not_to eq(result.get("message_decrypted"))

We are expecting the message field not to match the encrypted version in the message_decrypted

I am wondering if the line at https://github.com/logstash-plugins/logstash-filter-cipher/pull/18/files#diff-8046de15c827a600856f2cdb65db73edR153 is doing what we are actually expecting.

vktor18 commented 7 years ago

thanks @ph for the reply.

I don't understand which line are you referring in the link ..

ph commented 7 years ago

@vktor18

I am referring to theses lines, I wonder if they are problematic with the LS 5.0 API.

 if (event.get(@source).nil? || event.get(@source).empty?)
          @logger.debug("Event to filter, event 'source' field: " + @source + " was null(nil) or blank, doing nothing")
          return
        end
wiibaa commented 7 years ago

@vktor18 would be nice to add .idea/ to the git ignore