search

logstash-plugins / logstash-filter-cipher

Apache License 2.0
4 stars 28 forks source link

fixed encryption base64 encoding bug, +random ivs, + cipher reuse #2

Closed jsvd closed 9 years ago

jsvd commented 9 years ago

closes #1

bitsofinfo commented 9 years ago

Can this just be merged, then I can re-fork and fix the indentation. Getting confused as to how to properly do it at this point. The commits above seem to reference my orignal PR commits, but when I make an edit there, the latest commit is not showing up (indent fix) https://github.com/bitsofinfo/logstash-contrib/commit/c1d434e0597f9c7816050fe23d9571af00b16295

bitsofinfo commented 9 years ago

Can someone please give me a tip on where I should make these changes?

My original changes are here: https://github.com/bitsofinfo/logstash-contrib/blob/master/lib/logstash/filters/cipher.rb

Should I just make my changes there, and submit another PR?.... which I don't think will work because these are entirely 2 different projects now...

bitsofinfo commented 9 years ago

Please close this PR, it is replaced by https://github.com/logstash-plugins/logstash-filter-cipher/pull/3

jsvd commented 9 years ago

replaced by https://github.com/logstash-plugins/logstash-filter-cipher/pull/3