search

logstash-plugins / logstash-filter-date

Apache License 2.0
7 stars 43 forks source link

Raising exception if UNIX timestamp is out of range #73

Closed izhou99 closed 8 years ago

izhou99 commented 8 years ago

Fix as discussed in https://github.com/logstash-plugins/logstash-filter-date/pull/72

karmi commented 8 years ago

Hi @izhou99, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

izhou99 commented 8 years ago

@jordansissel can you take a look when you get a chance? Thanks!

jordansissel commented 8 years ago

LGTM

elasticsearch-bot commented 8 years ago

Jordan Sissel merged this into the following branches!

Branch Commits
master 9431976de579c65e34d1adf7ffbbfa8079f762de, 8ecd88a0fd0451a89f8f55c9a2a6283aa21112c8
jordansissel commented 8 years ago

I'm in the process of rewriting this filter (#73) and will be sure to include your lovely patch in it :) Thank you!

jordansissel commented 7 years ago

As a note, I am pretty sure I kept this functionality in #74 (a major rewrite of the plugin) because your new specs are passing there. However, just in case, if you see weird unix+unix_ms behavior, please let me know and we will fix it asap.

<3