Fix "escaped" \s* in regular expression.

logstash-plugins / logstash-filter-kv

Apache License 2.0

17 stars 42 forks source link

Fix "escaped" \s* in regular expression. #23

Closed untergeek closed 8 years ago

untergeek commented 8 years ago

This was causing issues with empty keys when spaces were present.

fixes #22

jordansissel commented 8 years ago

Good catch. In Ruby, "\s" is literally a space, so Regexp.new("\s*") would be the same as Regexp.new(" *") (matching hex 0x20 (space) only, not any whitespace)

jordansissel commented 8 years ago

Tests pass. Code LGTM.

andrewvc commented 8 years ago

LGTM ( Tests pass)

elasticsearch-bot commented 8 years ago

Aaron Mildenstein merged this into the following branches!

Branch	Commits
master	189cd92d7eedcda48748e310dc200280d7d2d633