search

logstash-plugins / logstash-filter-metrics

Apache License 2.0
15 stars 29 forks source link

Use sub-fields instead of dotted notation #23

Closed untergeek closed 9 years ago

untergeek commented 9 years ago

Prior implementations of the metrics filter plugin used dotted field names. Elasticsearch does not allow field names to have dots, beginning with version 2.0.

This PR changes the plugin behavior to be friendly with Elasticsearch 2.0 again by using sub-fields and removes examples with dots.

fixes #19

jordansissel commented 9 years ago

Overall code LGTM. Haven't tested.

jordansissel commented 9 years ago

Specs pass for me:

Finished in 0.385 seconds (files took 2.03 seconds to load)
19 examples, 0 failures
jordansissel commented 9 years ago

Let's call this version 3.0.0, after that, LGTM to merge.