logstash-plugins / logstash-output-google_cloud_storage

Apache License 2.0
9 stars 26 forks source link

Log UUID inclusion, fixes #23 #26

Closed josephlewis42 closed 6 years ago

josephlewis42 commented 6 years ago

Adds new flags to turn on/off the hostname in the log file name and whether or not to include a UUID in the file. This will allow users to match files with a single wildcard (to aid them in importing to BigQuery or other systems) and ensures files won't clobber one another if multiple instances of Logstash are running or an instance cycles up and down quickly.

josephlewis42 commented 6 years ago

@rosbo would you take a look when you get a chance? It's a slight refactor and two new pieces of functionality plus tests (yay!).

It should pave the way towards solving some of our longest standing issues around locking. It'll open up the way towards fixing #2 (from 2015) and #19 which will in turn open up #22 fixing #5. It'll also open up the possibility of changing upload file names to be whatever the user wants, including directories to fix #24.

I'm also hopeful that the pieces will be independent enough they could be pulled into bigquery to offer a "free mode" once again as an alternative to the streaming uploads.

josephlewis42 commented 6 years ago

I really like how easy it is to generate those builders in Ruby, good call!

The builds are failing right now for Logstash master and 6.X, they seem to have broken something upstream because it's also happening for Pub/Sub and bigquery.

jsvd commented 6 years ago

@josephlewis42 we sorted out the issues that were causing global failures in plugin tests, we can merge this now

josephlewis42 commented 6 years ago

@jsvd merged, built and tagged as v3.1.0, would you mind kicking off a release to rubygems? (unless the tag automatically does that)

jsvd commented 6 years ago

@josephlewis42 it doesn't unfortunately.. if you want to provide me with an email I'll add it as an owner of the gem so you can publish it too

josephlewis42 commented 6 years ago

@jsvd That would be awesome! jlewisiii@google.com should work, same josephlewis42 username as here.

jsvd commented 6 years ago

@josephlewis42 done: https://rubygems.org/gems/logstash-output-google_cloud_storage