search

logstash-plugins / logstash-output-google_cloud_storage

Apache License 2.0
9 stars 26 forks source link

add codec support #42

Closed colinsurprenant closed 5 years ago

colinsurprenant commented 5 years ago

This is a reboot of #34 by @josephlewis42.

I essentially only rebased against latest changes and added some minor fixes.

This PR adds proper support for codecs and deprecates the output_format config option. It is backward compatible in the sense that the output_format option will be translated to the equivalent codec option; output_format => json becomes codec => json_lines and output_format => plain becomes codec => line.

colinsurprenant commented 5 years ago

@danhermann thanks for the review. Note that there is no such output_format => codec option, simply omitting the output_format option will rely on the codec option, but if either the legacy output_format => json or output_format => plain options are used, they will be translated to their equivalent codec options. Let me know if that still makes sense.

danhermann commented 5 years ago

@danhermann thanks for the review. Note that there is no such output_format => codec option, simply omitting the output_format option will rely on the codec option, but if either the legacy output_format => json or output_format => plain options are used, they will be translated to their equivalent codec options. Let me know if that still makes sense.

Sorry, I shouldn't have used a Ruby operator there. I simply meant the transition from the deprecated output_format option to the codec option, not that output_format had a new codec option. 🙂

colinsurprenant commented 5 years ago

@danhermann 😆 gotcha!

colinsurprenant commented 5 years ago

Pushed a commit to fix a test that was flaky on 5.6. Will now squash (and preserve authorship history) and we should be good to publish.

colinsurprenant commented 5 years ago

published as v4.1.0 - thanks @josephlewis42 for your contribution.