search

logstash-plugins / logstash-output-newrelic

Output plugin based on New Relic Insights
Apache License 2.0
1 stars 4 forks source link

Publish to RubyGems #6

Open sschwartzman opened 8 years ago

sschwartzman commented 8 years ago

@suyograo I'm trying to publish this to rubygems, so that people can install it using bin/logstash-plugins. When I try with a local clone of this repo, I'm getting a 403. I'm guessing that's because I don't have access on this repo.

So, can you grant me that access, or help me publish the plugin another way?

Thanks, Seth

sschwartzman commented 8 years ago

Strangely enough, the publish worked, though it said it failed.

https://rubygems.org/gems/logstash-output-newrelic

Now how do I go about getting it into the published list of logstash-plugins so that bin/logstash-plugin works with it?

wiibaa commented 8 years ago

@sschwartzman on which LS version are you trying to install this plugin ? Because as you published the master branch, it can only be installed on 2.4 or 5.x, to make it available on 2.3 and below you should have a different gemspec with this line s.add_runtime_dependency "logstash-core-plugin-api", "~> 1.0" as it is done for other plugins in the plugin-api-v1 branch

sschwartzman commented 8 years ago

I'm not trying to install it, per se, but make it readily available to those that do want to install it. I have personally tested it most recently with 2.4, but I'm fine with changing the runtime dependency so it works with 2.3 as well. I don't have write access on this repo so I'd have to do another PR. Any way I can get write access?

Also, how does it get added to the list of logstash plugins so that it installs with logstash-plugins binary? (Not the local way using the .gem file, but remotely like the other plugins that are listed in Logstash's Gemfile.)

wiibaa commented 8 years ago

The fact that it is now published to rubygems with correct metadata is enough to make it installable with bin/logstash-plugin, but a gem published with logstash-core-plugin-api <= 2.99, >= 1.60 is only installable on 2.4 and 5.x. To make it compatible with 2.3 and lower the gem should be republished with a different-version and this restriction "logstash-core-plugin-api", "~> 1.0"

sschwartzman commented 8 years ago

Okay, can you explain to me how to republish the plugin with a "different-version"? I'm pretty newb to pushing to rubygems.