fixes #96 #100

[ncdm-stldr]

There are reports of a crash happening with newer versions of flutter (issues #96 and #100). This pull request aims to solve the crash.

Explanation of the changes:

• The renderer.close() in getPagesometimes creates an exception. It is because the close is already preformed by the try-catch clause itself. The code renderer.close() can therefore be safely removed.
• A else block has been added because it was missing (e.g. result should not been used twice).

[bruce-brookshire]

@lohanidamodar Can we get this merged soon? Great fix, needs to go in to unblock our development. Thanks

[husainazkas]

Ping @lohanidamodar

[joymyr]

@bruce-brookshire You can reference this branch in pubspec.yaml as a temporary workaround like this: advance_pdf_viewer: git: https://github.com/ncdm-stldr/pdf_viewer.git

[tsvillain]

@lohanidamodar Please Merge this and create a new release on pub.dev

[abhikhedekar4241]

@lohanidamodar Great fix, needs to unblock our development. Please get it merged soon.

[ncdm-stldr]

There is also this package which doesn't have the issue: https://pub.dev/packages/advance_pdf_viewer_fork

[ManuelRosa]

@lohanidamodar would it be possible to get this merged and released to pub.dev? The code is simple and seems sound

[igoswamirohit]

@lohanidamodar Can you please merge the Changes into your Master branch and Publish it on pub.dev ?

[rivella50]

@bruce-brookshire You can reference this branch in pubspec.yaml as a temporary workaround like this: advance_pdf_viewer: git: https://github.com/ncdm-stldr/pdf_viewer.git

It works fine with that version but as soon as i publish my app in release mode it crashes when trying to access cloud_firestore. Seems to me that this package uses too old versions of certain dependencies.

[UBONGFX]

Hello @lohanidamodar, we all would be very grateful if you would merge the changes into the master branch and publish it on pub.dev.