search

loilo / auto-group-tabs

Google Chrome extension to automatically group tabs by URL
https://chrome.google.com/webstore/detail/auto-group-tabs/danncghahncanipdoajmakdbeaophenb
MIT License
109 stars 19 forks source link

Add in the option for forcing single window #31

Closed j0be closed 2 years ago

loilo commented 2 years ago

Hey Ron, sorry for coming back to you so late on this.

Regarding this feature: Thank you for helping out. However, I will close this pull request as it does not consider quite a lot of edge cases that can happen with deduplicating groups across windows. Those are fixable problems, but I don't want to do an absurd amount of changes to your PR.

Since this feature has been requested multiple times, I will implement it, but I will do so in the main branch, although based on your PR. (Or rather, I have already done so, and I'm currently testing it on my machine.) To avoid situations like this, please start an issue/discussion before opening a pull request to a foreign project. I, as most maintainers, really appreciate the help, but there is virtually no situation where there wouldn't be things to sort out (regarding goals, feature design etc.) before diving into the implementation work.

Thanks again, and stay tuned for the feature. :)

j0be commented 2 years ago

Totally understand. That's a much better way of handling it. Thanks for your consideration!