Remove command can't remove folders

[loreanvictor]

After adding support for glob patterns to remove command, the remove command can't remove folders (sandbox).

This is because NodeFS.ls() only lists files and not folders. It does that, because update and copy commands can't semantically copy folders.

Potential remedies are:

• Adding an optional argument to filesystem.ls() to also list folders, update the implementation on NodeFS, and have the remove command use this option:

  export interface FileSystem {
  ...
  
  ls(path: string, directories?: boolean): Promsie<string[]>
  }

  This would mean that the remove command would also affect folders unlike copy and update commands, which can be confusing for users when using glob patterns in combination with the remove command. This confusion can be handled by adding an optional argument to remove itself to determine whether it should target directories or not.

• Changing implementation of the remove command, so that when no glob pattern is passed, it will remove folders properly.

This bug was first identified by @tommy-mitchel here.

[loreanvictor]

I think it'll be wise to first implement the second fix, since:

• It is straightforward and only affects @tmplr/core,
• It yields a predictable behavior that should remain intact in the future as well,
• It solves a good chunk of use cases.

As for the first solution, a few questions need to be answered first:

• When a glob pattern is given, which behavior is more expected / easier to understand? Removing folders by default? Or remaining consistent with other commands and only touching folders if specified?
• What are the use cases for removing folders using a glob pattern?

[loreanvictor]

I will close this issue for now, since removing folders by explicitly mentioning them seems to cover necessary use cases. If another use case comes up in the future, then this issue can be re-opened.